Recover from X11 WM hints send failures - #21
Draft
warp-agent-staging[bot] wants to merge 1 commit into
Draft
warp-agent-staging[bot] wants to merge 1 commit into
warp-agent-staging[bot] wants to merge 1 commit into
Conversation
1 of 4 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Treat an X11
WM_HINTSsend failure as recoverable when requesting user attention. This prevents a dead X11 connection from aborting the process while preserving the existing unchecked-cookie behavior after a successful send.Validation:
cargo test --lib --features x11 --no-default-features(8 passed)cargo clippy --all-targets --features x11 --no-default-features -- -D warningscargo fmt --allTested on all platforms changed
Added an entry to the
changelogmodule if knowledge of this change could be valuable to users — internal error-handling fix onlyUpdated documentation to reflect any user-facing changes, including notes of platform-specific behavior — no API or documented behavior change
Created or updated an example program if it would help users understand this functionality — not applicable
Updated feature matrix, if new features were added or implemented — no feature change
This PR was created by Warp (running Codex).